PlasmaShop 3

[Zrax]

I was actually aware of this slowdown as well, although I haven't done anything about it yet... Unfortunately, regex matching does take time, so scanning dat several times is indeed likely to cause it to be pretty slow. The Delphi version (2.x) just uses normal filesystem glob matching, which is faster, but still doesn't really eliminate the problem... Actually, that's what I wanted to do for the Qt version too, but it wanted regex, so I used that for now >.>.

I like your idea, and perhaps I can take it to the next level; specifically, by scanning the entire game directory and filtering files into their respective directories as they're found, rather than only looking for files when we need them. That way, we're more likely to get all the files we want (this would eliminate the problem you had with duplicate log file entries entirely), and would inherantly speed up the scan process significantly. In short: great suggestion!

[diafero]

I'm not sure if doing it for the other directories (besides dat) is worth the effort - you have that recursive convenience function there, and most importantly they are not scanned multiple times. So I'd leave them as-is. If I recall the code correctly, the dat scanning is the only one not using RecursiveAddFiles, so it is kind of separate anyway. Your suggestion would be more like a re-write, requiring me to dig much deeper into the sources and understand the way you are saving the game directory - if you have too much to do or want me to do the patch for other reasons, I think I'd go the easier route. However, if you say you'll do it yourself, I agree a full scan would be the cleaner solution (maybe with an additional "folder" being added to your view collecting unknown purpose files).

[Zrax]

Oh, I didn't realize you were offering to do it... If I do it myself, I'd definitely be more likely to choose the cleaner solution (handling the whole directory at once), possibly even with a filesystem notifier for added/deleted/modified files... I realize what you're saying about not needing to worry about the other directories, but remember that in the current implementation, it's still matching the regex on every file anyway, so the speed benefit would still apply in these cases. Anyway, if you really want to do it, I'll let you, but otherwise I'll probably just implement the full scan solution sometime this week or weekend

[diafero]

Well, I could not even start before this weekend, so go ahead

[diafero]

After your latest commits, startup time is comparable to the one of PlasmaShop2 with wine - thanks a lot

[diafero]

I encountered some weird effects with the new file processing:
- First of all, the "dummy" age files Drizzle creates in dat/dummyages are now also listed as age in PlasmaShop
- Second, the pages are no longer in a "subfolder" - is that on purpose?
- And third, the fni files in the ini directory end up in the "Ages" folder...
Nevertheless, the speed improvement is great, so these are just minor drawbacks

[Zrax]

- First of all, the "dummy" age files Drizzle creates in dat/dummyages are now also listed as age in PlasmaShop

Ah yes, easy fix though...

- Second, the pages are no longer in a "subfolder" - is that on purpose?

Yes, it is... I was originally redesigning it to work the same as the old way, but I realized there was no real reason to put the PRP files in their own subfolder... Plus, then I'd have to re-sort the folders in each age, since the "Districts" folder was only a meta-folder anyway

- And third, the fni files in the ini directory end up in the "Ages" folder...

Ok, again an easy fix...

Thanks again!

EDIT: And fixed. I'll wait to update the prebuilt Windows binaries though until I finish the .sum file editor I'm working on now...