Bug in Offline KI 3.6.1

Announcements and discussion regarding any projects related to Cyan Worlds' Plasma Engine including (but not limited to) CyanWorlds.com Engine, Drizzle, OfflineKI, PyPRP, and libHSPlasma.

Bug in Offline KI 3.6.1

Postby sekournen » Tue Feb 07, 2012 5:48 pm

Hey just thought people should know after installing the offline KI it caused several bugs in the Kadish Tolesa age, well it did for me at least. It makes the pillar puzzle not function as well as not putting the sanctuary book in the bookshelf at relto. just fyi (>o.o<)
sekournen
 
Posts: 1
Joined: Tue Feb 07, 2012 5:23 pm

Re: Bug in Offline KI 3.6.1

Postby Sirius » Wed Feb 08, 2012 4:50 am

About the pillar room: do you have the sparkly (addition from MO:ULa) installed ?

I'm pretty sure it has to do something with the fix D'Lanor added to make sure it is parented to the pillar.
In the pillar script:
Code: Select all
        objSparklyDecal = PtFindSceneobject('CalendarStarDecal', PtGetAgeName()) # leave the spark and the regions where they are, they are not supposed to move
        objPillar = PtFindSceneobject('pillar03', PtGetAgeName())
        dst = objPillar.position()
        xUserKI.WarpObjectToPos(objSparklyDecal, dst.getX(), dst.getY(), dst.getZ()) # warp decal to pillar (it will be just at the top)
        PtAttachObject(objSparklyDecal.getKey(), objPillar.getKey()) # and attach the two to each other
I think it should be:
Code: Select all
        try: # don't fail if there is no sparkly
            objSparklyDecal = PtFindSceneobject('CalendarStarDecal', PtGetAgeName()) # leave the spark and the regions where they are, they are not supposed to move
        except:
            print "No sparkly to attach"
        else:
            objPillar = PtFindSceneobject('pillar03', PtGetAgeName())
            dst = objPillar.position()
            xUserKI.WarpObjectToPos(objSparklyDecal, dst.getX(), dst.getY(), dst.getZ()) # warp decal to pillar (it will be just at the top)
            PtAttachObject(objSparklyDecal.getKey(), objPillar.getKey()) # and attach the two to each other
It first looks for the two objects to attach, then parent them, then some other instructions about the pillars are executed. Which means these are skipped if the engine can't find the sparkly object.

As for the book, the way the Relto bookshelf works is different in the Offline-KI (with the new book covers and books for fan-Ages). I'll leave this to someone who knows better how it is supposed to work.
User avatar
Sirius
 
Posts: 1147
Joined: Mon Jul 26, 2010 4:46 am
Location: France

Re: Bug in Offline KI 3.6.1

Postby Tsar Hoikas » Wed Feb 08, 2012 7:40 am

That fix looks correct. If the sparkly is not in the age, the script will crash without the try... catch. Once an instance of a script crashes, Uru blacklists it and won't try to run any portion of it again.
Image
User avatar
Tsar Hoikas
Councilor of Technical Direction
 
Posts: 1887
Joined: Fri Nov 16, 2007 9:45 pm
Location: South Georgia

Re: Bug in Offline KI 3.6.1

Postby diafero » Wed Feb 08, 2012 10:31 am

I added the patch to the Offline KI, thanks. It will be in the next release, which I will do after my exams (end of February). Thanks for finding and fixing it!

Do you mean the Watcher's Sanctuary? You don't have to collect that book, it's right there from the start.
If it is not, could you please start Uru, and quit immediately, and send me the Python.0.elf file (see my signature for my email address)?
I prefer e-mails to "diafero arcor de" (after adding the at and the dot) over PMs.

"Many people's horizon is a circle with a radius of zero. They call it their point of view."

Deep Island Shard | Offline KI
diafero
Deep Island Admin
 
Posts: 2806
Joined: Mon May 05, 2008 5:50 am
Location: Germany

Re: Bug in Offline KI 3.6.1

Postby D'Lanor » Wed Feb 08, 2012 2:25 pm

Just for the record, that safety catch was present in my code example. ;)
"It is in self-limitation that a master first shows himself." - Goethe
User avatar
D'Lanor
 
Posts: 1980
Joined: Sat Sep 29, 2007 4:24 am

Re: Bug in Offline KI 3.6.1

Postby diafero » Thu Feb 09, 2012 3:20 am

As the comment says: "fix (partially by D'Lanor) to attach sparkly to pillar" - the buggy part is naturally the one I wrote ;-)
I prefer e-mails to "diafero arcor de" (after adding the at and the dot) over PMs.

"Many people's horizon is a circle with a radius of zero. They call it their point of view."

Deep Island Shard | Offline KI
diafero
Deep Island Admin
 
Posts: 2806
Joined: Mon May 05, 2008 5:50 am
Location: Germany


Return to Plasma Development

Who is online

Users browsing this forum: No registered users and 1 guest

cron